add words on Enumeration range formatting #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaitkus
reviewed
Jun 26, 2023
There was a problem hiding this comment.
I suggested minor wording changes to make the suggestion more similar to the rest of the text.
Also, the version, changelog and other metadata items in the text should be updated.
As a side note, it would be best if in the future the changes in the PR would not include additional formatting changes such as white space removal as it makes the PR harder to review. I replicated the whitespace changes in the trunk, so they no longer appear in the PR diff.
|
Looks good, I think we need to bump the minor version and date, and add to the Changelog at the bottom. We also need to update for new DDL attributes which we could do in the same version. |
Co-authored-by: Antanas Vaitkus <[email protected]>
Co-authored-by: Antanas Vaitkus <[email protected]>
Co-authored-by: Antanas Vaitkus <[email protected]>
Co-authored-by: Antanas Vaitkus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #19
Integer ranges have no decimal point. Real ranges have a decimal point and at least one digit after the decimal point.